Defining Gateways SLOs w/ Alerting#40
Merged
Merged
Conversation
joshlreese
suggested changes
Jul 25, 2025
joshlreese
suggested changes
Jul 28, 2025
joshlreese
left a comment
joshlreese
left a comment
Contributor
There was a problem hiding this comment.
Came across some issues in the GatewayNotReadySLOViolation alert that need a closer look.
Is there any work being done to place gateways into conditions that violate these SLOs in order to confirm they're functioning as expected?
…_com_project_name for differentiating series between projects.
scotwells
approved these changes
Sep 11, 2025
scotwells
left a comment
scotwells
left a comment
Contributor
There was a problem hiding this comment.
@OscarLlamas6 changes look good. It would be good if these tests were executed by GitHub Actions. Maybe something we can create a shared action for? Can be done in a follow up PR / issue.
joshlreese
approved these changes
Sep 12, 2025
joshlreese
left a comment
joshlreese
left a comment
Contributor
There was a problem hiding this comment.
Great use of promtool tests - I was able to execute these locally and confirm failures if I adjusted series values to not be as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests for prometheus rules config/telemetry/alerts/gateways.yaml